feat(lockfile): default to lockfile v5 #28950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the default lockfile version from v4 to v5, thereby replacing the previous version identifier in test assertions and related integrations. Key changes include:
- Updating all tests in the integration suite that compare against lockfile version “4” to now expect version “5” and, in some cases, validating additional fields such as “tarball” URLs.
- Removing the unstable “lockfile_v5” flag from the CLI and related modules and instead defaulting to using lockfile v5.
- Making corresponding adjustments in npm snapshot resolution and configuration parsing to align with the new lockfile v5 format.
Reviewed Changes
Copilot reviewed 53 out of 60 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/integration/* | Updated expected lockfile JSON in tests from version “4” to “5” and added tarball fields. |
| cli/args/lockfile.rs | Removed the dynamic “use_lockfile_v5” flag and now hard-coded lockfile version support. |
| cli/args/* and cli/lib/args.rs | Removed references to unstable_lockfile_v5 and adjusted CLI argument handling accordingly. |
| cli/npm/managed.rs | Adapted snapshot resolution to use lockfile v5 exclusively. |
Files not reviewed (7)
- tests/specs/add/update_lockfile_if_package_json/lockfile_add.out: Language not supported
- tests/specs/add/update_lockfile_if_package_json/lockfile_remove.out: Language not supported
- tests/specs/cache/package_json/deno.lock.out: Language not supported
- tests/specs/future_install_node_modules/test.jsonc: Language not supported
- tests/specs/future_install_node_modules/deno.lock.out: Language not supported
- tests/specs/install/future_install_local_deno/deno.lock.out: Language not supported
- tests/specs/install/future_install_node_modules/deno.lock.out: Language not supported
Comments suppressed due to low confidence (3)
tests/integration/run_tests.rs:489
- Ensure that tests verifying the lockfile content are updated to also check for any additional fields (e.g. tarball URLs) introduced with lockfile v5.
"version": "5",
cli/args/lockfile.rs:305
- Verify that setting 'next_version' to true unconditionally aligns with the intended v5 behavior and that no edge cases are missed during lockfile validation.
next_version: true,
cli/args/mod.rs:1089
- [nitpick] Since references to unstable_lockfile_v5 have been removed, ensure that every part of the codebase now consistently uses the default lockfile v5 behavior and that any legacy code paths are fully deprecated.
pub fn unstable_lockfile_v5(&self) -> bool { ... }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #28916