fix(ext/node): add support for --no- prefix in parseArgs() #28811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the test case. Looks like the added case are passing with this implementation (with a small fix). Nice work! You can check it with the command: |
nayeemrmn
pushed a commit
that referenced
this pull request
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #28606
I have the implementation working and validated against the Node.js tests. I'm looking for knowledge on integrating the tests properly.
The existing parseArgs tests seem to be managed by a script that pulls them from Node.js. What's the preferred approach: update the files generated by that script, or add these tests separately? Also, what version of Node will the newly pulled tests come from?