Skip to content

fix(ext/node): mkdir() parse file mode #28609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2025
Merged

fix(ext/node): mkdir() parse file mode #28609

merged 1 commit into from
Mar 25, 2025

Conversation

littledivy
Copy link
Member

Fixes #28604

marvinhagemeister
marvinhagemeister approved these changes Mar 24, 2025
View reviewed changes
Copy link
Contributor

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@littledivy littledivy merged commit 52d528d into denoland:main Mar 25, 2025
18 checks passed
littledivy added a commit that referenced this pull request Mar 28, 2025
@littledivy
fix(ext/node): mkdir() parse file mode (#28609)
7ca3d9c 
Fixes #28604
ry pushed a commit that referenced this pull request Apr 7, 2025
@littledivy @ry
fix(ext/node): mkdir() parse file mode (#28609)
bef35c3 
Fixes #28604
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: node:fs mkdir mode option crashes on string
2 participants
@littledivy @marvinhagemeister