fix(runtime): remove deno_os::deno_os_worker to make WebWorker work without snapshot
#28693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For reviewers: please consider which one is a better solution: |
bartlomieju
reviewed
Apr 17, 2025
There was a problem hiding this comment.
The solution proposed in the issue is a better one in this case - the change in this PR makes it so an accidental refactor could break the worker code - having ExitCode present in the OpState is an invariant that we expect to be upheld. I would suggest to shim out these two ES modules in your code instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #28680. Sorry for submitting this without awaiting a response.