Skip to content

fix: show referrer for Wasm module dependency errors #28653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2025
Merged

fix: show referrer for Wasm module dependency errors #28653

merged 1 commit into from
Mar 28, 2025

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Mar 27, 2025 •
edited
Loading

@dsherret dsherret changed the title fix: show referrer for wasm module dependency errors fix: show referrer for Wasm module dependency errors Mar 27, 2025
marvinhagemeister
marvinhagemeister approved these changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 1e65d21 into denoland:main Mar 28, 2025
18 checks passed
@dsherret dsherret deleted the fix_wasm_module_importing_specifier_missing_referrer branch March 28, 2025 13:13
littledivy pushed a commit that referenced this pull request Apr 4, 2025
@dsherret @littledivy
fix: show referrer for Wasm module dependency errors (#28653)
8ab7d2b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wasm module importing specifier that can't be resolved is missing referrer in error message
2 participants
@dsherret @marvinhagemeister