fix: add stackTraceLimit to ErrorConstructor interface and removed ErrorWithStackTraceLimit interface #28539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…now on the ErrorConstructor interface Signed-off-by: Jake Champion <me@jakechampion.name>
Signed-off-by: Jake Champion <me@jakechampion.name>
|
|
|
Ah, I should have made the title not mention about something internal removed. For anyone looking at this PR, nothing was removed from the public api. |
|
Thanks @JakeChampion ! |
ry
pushed a commit
that referenced
this pull request
Mar 21, 2025
…rorWithStackTraceLimit interface (#28539) Signed-off-by: Jake Champion <me@jakechampion.name>
ry
pushed a commit
that referenced
this pull request
Apr 7, 2025
…rorWithStackTraceLimit interface (#28539) Signed-off-by: Jake Champion <me@jakechampion.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When upgrading to Deno 2.x from 1.x I noticed that my project began to get the below error from deno-ts:
Looking through the deno codebase I saw that there wasa todo item to add this field, which is why I have opened this pull-request