fix(ext/websocket): cancel in-flight handshake on close() #28598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
798455c to
4d85486
Compare
ry
reviewed
Mar 27, 2025
Comment on lines
+264
to
+265
| if (this[_cancelHandle]) { | ||
| core.tryClose(this[_cancelHandle]); |
There was a problem hiding this comment.
should there also be
this[_cancelHandle] = undefined;
here like the other block added below?
ry
requested changes
Mar 27, 2025
There was a problem hiding this comment.
I'm testing this locally and whether or not I run the target/debug/test_server the test passes... that seems problematic
Running
cargo run --bin deno -- test -A --location=http://js-unit-tests/foo/bar --config=tests/config/deno.json --filter="websocket close ongoing handshake" tests/unit/websocket_test.ts
ry
approved these changes
Mar 28, 2025
littledivy
added a commit
that referenced
this pull request
Mar 28, 2025
Fixes #25126 --------- Co-authored-by: Ryan Dahl <ry@tinyclouds.org>
ry
added a commit
that referenced
this pull request
Apr 7, 2025
Fixes #25126 --------- Co-authored-by: Ryan Dahl <ry@tinyclouds.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25126