fix(lsp): do not show import-map-remap diagnostic when referrer and target are within the entry base #28560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Mar 20, 2025
cli/lsp/diagnostics.rs
Outdated
| if entry.raw_value == Some("./") { | ||
| // ignore `./` entries because it creates a | ||
| // diagnostic for every relative import | ||
| continue; |
There was a problem hiding this comment.
I confirmed the test fails without this.
./ value
ry
pushed a commit
that referenced
this pull request
Mar 21, 2025
…arget are within the entry base (#28560) For example, if someone has `"$src/": "./src"` in their import map, this will no longer show a diagnostic when someone imports `"./a.ts"` from ./src/b.ts`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, if someone has
"$src/": "./src"in their import map, this will no longer show a diagnostic when someone imports"./a.ts"from ./src/b.ts`Closes #17867