fix(ext/node): support the optional previousValue parameter for process.cpuUsage()
#28550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adfbb55 to
1c454ac
Compare
JakeChampion
commented
Mar 25, 2025
ccad420 to
17877eb
Compare
JakeChampion
commented
Mar 31, 2025
37178c4 to
1bc62ff
Compare
…arameter correctly
…age() The process.cpuUsage method when called with a parameter, will compute the diff between the current cpu-usage and the supplied cpu-usage values
previousValue parameter for process.cpuUsage()previousValue parameter for process.cpuUsage()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The process.cpuUsage method when called with a parameter, is meant to compute the diff between the current cpu-usage and the supplied cpu-usage values
This should make /tests/node_compat/test/pummel/test-process-cpuUsage.js begin to pass