Skip to content

fix(unstable): lint plugin child combinator not working with groups #28360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2025
Merged

fix(unstable): lint plugin child combinator not working with groups #28360

merged 1 commit into from
Mar 3, 2025

Conversation

marvinhagemeister
Copy link
Contributor

Internally, we use a group node for array-like children, which is hidden from the user. When we're asking for a parent of a node we need to take group nodes into account and walk over them.

Fixes one issue reported in #28355

@marvinhagemeister
fix(unstable): lint plugin child combinator not working with groups
54c0713 
Internally, we use a group node for array-like children, which is hidden from the user. When we're asking for a parent of a node we need to take group nodes into account and walk over them.
nathanwhit
nathanwhit approved these changes Mar 3, 2025
View reviewed changes
Copy link
Member

@nathanwhit nathanwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marvinhagemeister marvinhagemeister merged commit 842a906 into main Mar 3, 2025
18 checks passed
@marvinhagemeister marvinhagemeister deleted the lint-group-parent branch March 3, 2025 20:44
littledivy pushed a commit that referenced this pull request Mar 5, 2025
@marvinhagemeister @littledivy
fix(unstable): lint plugin child combinator not working with groups (#…
6f171ce 
…28360)

Internally, we use a group node for array-like children, which is hidden
from the user. When we're asking for a parent of a node we need to take
group nodes into account and walk over them.

Fixes one issue reported in
#28355
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanwhit nathanwhit nathanwhit approved these changes

@dsherret dsherret Awaiting requested review from dsherret

@littledivy littledivy Awaiting requested review from littledivy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marvinhagemeister @nathanwhit