Skip to content

fix(unstable): Missing PrivateIdentifier type for PropertyDefinition key #28358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2025
Merged

fix(unstable): Missing PrivateIdentifier type for PropertyDefinition key #28358

merged 1 commit into from
Mar 3, 2025

Conversation

marvinhagemeister
Copy link
Contributor

The PropertyDefinition node also allows PrivateIdentifier as a type for the key. Example:

class Foo {
  #foo = 2;
}

Fixes one issue reported in #28355

@marvinhagemeister marvinhagemeister merged commit 62bc078 into main Mar 3, 2025
18 checks passed
@marvinhagemeister marvinhagemeister deleted the lint-property-private branch March 3, 2025 10:03
littledivy pushed a commit that referenced this pull request Mar 5, 2025
@marvinhagemeister @littledivy
fix(unstable): Missing PrivateIdentifier type for `PropertyDefiniti…
2a2ffa4 
…on` key (#28358)

The `PropertyDefinition` node also allows `PrivateIdentifier` as a type
for the `key`. Example:

```ts
class Foo {
  #foo = 2;
}
```

Fixes one issue reported in
#28355
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littledivy littledivy littledivy approved these changes

@dsherret dsherret Awaiting requested review from dsherret

@nathanwhit nathanwhit Awaiting requested review from nathanwhit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marvinhagemeister @littledivy