fix(run): skip the cjs suggestion for mjs/mts modules #26698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…if one of them detected
…Su1/my_deno into cjs_suggestions_for_mjs
|
Could you please add a test that uses |
|
Sure! I will add a test asap |
|
When I try to add a test that uses a .cts file, it shows me the following error: |
|
@MohammadSu1 can you push the failing test to the PR? |
…Su1/my_deno into cjs_suggestions_for_mjs
…Su1/my_deno into cjs_suggestions_for_mjs
|
@dsherret I tried fixing the issue in the test and pushed it to the PR. I think it's working correctly now |
|
@dsherret Can you please review this PR? |
|
@bartlomieju Can you please review this PR? |
|
@dsherret Can you review this PR? |
|
@dsherret Can you review this PR, please? |
dsherret
approved these changes
Mar 5, 2025
ry
pushed a commit
that referenced
this pull request
Mar 14, 2025
Co-authored-by: David Sherret <dsherret@gmail.com>
ry
pushed a commit
that referenced
this pull request
Apr 7, 2025
Co-authored-by: David Sherret <dsherret@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for solving #26557.