-
Notifications
You must be signed in to change notification settings - Fork 5.7k
feat(ext/fs): add isBlockDevice, isCharDevice, isFifo, isSocket to FileInfo #19008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Please turn the PR into a draft until it is ready for review / test running. |
when add isBlockDevice < "exportMapKey": String("foo|6846|file:///a/b"),
> "exportMapKey": String("foo|6845|file:///a/b"), when add isBlockDevice, isCharDevice, isFifo, isSocket < "exportMapKey": String("foo|6849|file:///a/b"),
> "exportMapKey": String("foo|6845|file:///a/b"), I have yet to figure out if this is a fatal change... |
It's not, it's expected. TypeScript provides completions that can change when new APIs appear. I've rebased the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
recreate #16064
isFile
,isDirectory
,isSymlink
are defined inDeno.FileInfo
, butisBlockDevice
,isCharacterDevice
,isFIFO
,isSocket
are not defined.These are defined in Node.js fs.Stats, and it is good to be defined in
Deno.FileInfo
to improve compatibility.