Skip to content

fix(ext/crypto): deriveBits for ECDH not taking length into account #16128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2022
Merged

fix(ext/crypto): deriveBits for ECDH not taking length into account #16128

merged 1 commit into from
Oct 4, 2022

Conversation

Nautigsam
Copy link
Contributor

Fixes #16047

@CLAassistant
Copy link

CLAassistant commented Oct 1, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Nautigsam Nautigsam force-pushed the dev/derive_bits branch 3 times, most recently from ffbf15d to 8681370 Compare October 2, 2022 13:24
littledivy
littledivy reviewed Oct 3, 2022
View reviewed changes
littledivy
littledivy approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks. Needs one minor fix for the CI to pass

panva
panva suggested changes Oct 3, 2022
View reviewed changes
@Nautigsam Nautigsam force-pushed the dev/derive_bits branch 3 times, most recently from f7e16ba to d747f4f Compare October 3, 2022 18:59
@littledivy littledivy merged commit 8d20784 into denoland:main Oct 4, 2022
@panva panva mentioned this pull request Oct 4, 2022
Merged
@Nautigsam Nautigsam deleted the dev/derive_bits branch October 4, 2022 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littledivy littledivy littledivy approved these changes

+1 more reviewer

@panva panva panva requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong buffer length from deriveBits
5 participants
@Nautigsam @CLAassistant @panva @diachedelic @littledivy