Skip to content

fix(npm): panic on invalid package name #16123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 3, 2022
Merged

fix(npm): panic on invalid package name #16123

merged 3 commits into from
Oct 3, 2022

Conversation

bartlomieju
Copy link
Member

Closes #16092

@bartlomieju bartlomieju requested a review from dsherret October 1, 2022 13:02
dsherret
dsherret approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 8e1b2fc into denoland:main Oct 3, 2022
@bartlomieju bartlomieju deleted the npm_panic_invalid_package branch October 3, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

@littledivy littledivy littledivy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deno panic on invalid "npm:" import
3 participants
@bartlomieju @dsherret @littledivy