Skip to content

feat(fs): Add isBlockDevice to FileInfo #16064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 13 commits into from
Closed

feat(fs): Add isBlockDevice to FileInfo #16064

wants to merge 13 commits into from

Conversation

wafuwafu13
Copy link
Contributor

@wafuwafu13 wafuwafu13 commented Sep 28, 2022 •
edited
Loading

std::os::unix::fs::FileTypeExt is defined in Rust.
isFile, isDirectory, isSymlink are defined in Deno.FileInfo, but isBlockDevice, isCharacterDevice, isFIFO, isSocket are not defined.
These are defined in Node.js fs.Stats, and it is good to be defined in Deno.FileInfo to improve compatibility.
In this PR, isBlockDevice is defined. If this PR is approved, I will add isCharacterDevice, isFIFO, isSocket as well in next PR.

@wafuwafu13 wafuwafu13 marked this pull request as draft September 28, 2022 08:36
@wafuwafu13 wafuwafu13 marked this pull request as ready for review September 29, 2022 01:04
littledivy
littledivy reviewed Oct 3, 2022
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favour.

Although I should point out that we have too many fields in FileInfo. Deno does not have an API for exists / access. Those cases will use Deno.stat and won't be accessing these meta fields at all.

aapoalas
aapoalas approved these changes Feb 11, 2023
View reviewed changes
Copy link
Contributor

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: Can you rebase this?

aapoalas
aapoalas suggested changes Mar 25, 2023
View reviewed changes
Copy link
Contributor

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires a rebase.

@wafuwafu13 wafuwafu13 mentioned this pull request Apr 4, 2023
Closed
@wafuwafu13
Copy link
Contributor Author

wafuwafu13 commented Apr 4, 2023 •
edited
Loading

@aapoalas
I retry at #19008
I apologize for the delayed response.

@wafuwafu13 wafuwafu13 closed this Apr 4, 2023
@wafuwafu13 wafuwafu13 mentioned this pull request May 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littledivy littledivy littledivy left review comments

+1 more reviewer

@aapoalas aapoalas aapoalas requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wafuwafu13 @aapoalas @littledivy