Skip to content

remove calls to futures::executor::block_on #4760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 16, 2020
Merged

remove calls to futures::executor::block_on #4760

merged 4 commits into from
Apr 16, 2020

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Apr 15, 2020 •
edited
Loading

Remove futures::executor::block_on calls from:

  • cli/resolve_addr.rs - remove dummy future, use sync version
  • fs events
  • TS compiler - replace with dedicated method on SourceFileFetcher to fetch cached filed

@bartlomieju bartlomieju changed the title [WIP] remove calls to futures::executor::block_on remove calls to futures::executor::block_on Apr 15, 2020
@bartlomieju bartlomieju requested a review from ry April 15, 2020 19:22
ry
ry approved these changes Apr 16, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ry ry merged commit aab26d2 into denoland:master Apr 16, 2020
@bartlomieju bartlomieju deleted the remove_block_on branch April 16, 2020 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartlomieju @ry