Skip to content

Replace panic with invalid_utf8 OpError #4704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2020
Merged

Replace panic with invalid_utf8 OpError #4704

merged 1 commit into from
Apr 11, 2020

Conversation

gewoonwoutje
Copy link
Contributor

Related to #1489

A simple change to return an invalid UTF8 OpError instead of panicking. It still dies on UTF8 encoded files, but at least cleans up the message.

@CLAassistant
Copy link

CLAassistant commented Apr 10, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

ry
ry reviewed Apr 10, 2020
View reviewed changes
ry
ry approved these changes Apr 11, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@ry ry merged commit 2feb661 into denoland:master Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gewoonwoutje @CLAassistant @ry