fix(cli/js/net): Make generator return types iterable #4661
Conversation
|
I don't really understand. Why would you want to do that? |
|
That's how generators are defined everywhere else, this was a mistake. Generators provide this property but those type defs are hiding it. If it really needs a use case, I suppose there is a different behaviour for two loops sharing the same iterator object which might be useful to someone. |
There was a problem hiding this comment.
That's how generators are defined everywhere else, this was a mistake. Generators provide this property but those type defs are hiding it. If it really needs a use case, I suppose there is a different behaviour for two loops sharing the same iterator object which might be useful to someone.
This type declaration confirms that:
https://github.com/microsoft/TypeScript/blob/712967b2780e8ecd28f8f1e2e89c1ebd2592bb4c/lib/lib.es2018.asynciterable.d.ts#L32-L45
LGTM
Strengthens the type so this doesn't throw a type error:
i.e the iterators are also iterable.