Skip to content

feat(worker): add MessageEvent, ErrorEvent and handling to Worker API #4391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Apr 13, 2020
Merged

feat(worker): add MessageEvent, ErrorEvent and handling to Worker API #4391

merged 13 commits into from
Apr 13, 2020

Conversation

crowlKats
Copy link
Member

crowlkats and others added 2 commits March 16, 2020 10:45
Add worker events
35293d2
@bartlomieju
temp
5721717 
(cherry picked from commit ff2d889)
bartlomieju
bartlomieju reviewed Mar 16, 2020
View reviewed changes
@crowlKats
Copy link
Member Author

@bartlomieju updated

nayeemrmn
nayeemrmn reviewed Mar 16, 2020
View reviewed changes
nayeemrmn
nayeemrmn reviewed Mar 16, 2020
View reviewed changes
@crowlKats
Copy link
Member Author

@bartlomieju the test cases seem to fail

bartlomieju
bartlomieju reviewed Mar 18, 2020
View reviewed changes
bartlomieju
bartlomieju reviewed Mar 18, 2020
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crowlKats looking good

@aduh95
Copy link
Contributor

aduh95 commented Apr 10, 2020

Fixes #4344

@bartlomieju bartlomieju changed the title Add worker events feat(worker): add MessageEvent, ErrorEvent and handling to Worker API Apr 13, 2020
@bartlomieju bartlomieju requested a review from ry April 13, 2020 12:17
@bartlomieju
Copy link
Member

@crowlKats sorry for slow review, I merged master and did update your PR a bit. Good work 👍

@bartlomieju bartlomieju merged commit 25bd686 into denoland:master Apr 13, 2020
@crowlKats crowlKats deleted the worker_events branch April 13, 2020 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nayeemrmn nayeemrmn nayeemrmn left review comments

@bartlomieju bartlomieju bartlomieju approved these changes

@ry ry Awaiting requested review from ry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crowlKats @aduh95 @bartlomieju @nayeemrmn