-
Notifications
You must be signed in to change notification settings - Fork 329
Add skip layer guidance #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add skip layer guidance #61
Conversation
@deepbeepmeep Unfortunately I don't have time to add it to the gradio, but it should be pretty simple to do so. Maybe you can merge and take care of that? |
Credits to AmericanPresidentJimmyCarter: deepbeepmeep/Wan2GP#61
output_sm.mp4Other layer skips, since people were asking for it. Most of them are detrimental aside from 9 or 10. |
f05dcb0
to
936db03
Compare
Hi @AmericanPresidentJimmyCarter, very amazing work! I did simple tests and the results indeed improved. Could you kindly explain the reason behind this? |
If anyone else testing with more examples can post here would be nice I wonder if worth to implement or not |
There's a lot of discussion in the reddit thread. |
Many thanks for your contribution. Do you have more examples that illustrate the quality gain ? |
output_anime_combined.mp4Here is one yesterday with skipping layer 10, with anime style. You can see that the skipped layer version is less soupy, has more consistent lines, and smoother animation.. I've been meaning to play with it more but haven't had the chance. Sometimes you need to set it to not do the first 10% or so of timesteps, because it can severely disrupt the planning stage of denoising. Below is one where I had layer 10 skipped throughout 100% of the steps. output_slg_anime_0_1.mp4 |
Thanks, slg, is now part of the gradio webserver of Wan2GP as it seems to improve the quality (it is a placebo ?). I did commit new features as well for Wan2GP. Hopefully I didnt break your command line version. |
Of course you'll do it, won't you? I'm curious, have you ever submitted a single useful pull request, or do you simply make money by profiting from the labor of others? |
modelscope/DiffSynth-Studio#442 |
I must admit, I'm impressed by the fact you've made a few PRs. 🫨 I'm not sure what you're trying to achieve by showing my profile. I'm not a dev, and I don't make money by profiting from the work of others like you do. |
Having messed around extensively with this now, it definitely works. The effects are best if you're using teacache 0.15-0.25, which can degrade the model output significantly. |
Oh, someone published a paper on this too. I hadn't read it before implementing it, but it may convince some people of the potential utility. |
Mr president @AmericanPresidentJimmyCarter, any plan to implement this in ComfyUI ? |
Nvm, someone has already done it! https://www.reddit.com/r/StableDiffusion/comments/1jd0kew/skip_layer_guidance_is_an_impressive_method_to/ |
Add skip layer guidance
Skip layer guidance can dramatically enhance the quality of output videos.
output_combined.mp4