Use macdeployqt #648
Use macdeployqt #648
Conversation
…cript to create the `.app` bundle
Have CMake always build a bundle, the `build_dist.sh` script will only build a dmg if the build type is "Release"
…ef_dylibs.sh` manually
…x-count` on `grep`.
|
Despite the Azure Pipeline for Mac Build Release failing, this builds successfully on 10.14 Mojave with either Homebrew or MacPorts. The build failing seems to have something to do with OpenSSL and linking |
Which macOS releases are we leaving behind due to this change? |
|
Just want to confirm that I was getting this same error, and with this new update I was able to successfully build a snapshot using |
None that haven't already been left behind by 2.3.2-Release. It should compile/run on anything still supported by Qt/Xcode. I just didn't want to remove the old scripts in case it was part of someone's workflow. |
macdeployqt needs "-executable=filename" to propery change linking on other variables also renamed the cmake target from "Barrier_dmg" to "Barrier_MacOS" to properly reflect earlier changes
|
I had forgotten to manually specify |
The Azure Pipelines MacOS vmImage has an old version of OpenSSL (1.0.2t) installed at /usr/local/opt/openssl. Normally with Homebrew this directory would be linked to the currenly installed version of OpenSSL (1.1.x) in /usr/local/Cellar, but since it has been installed manually here it interferes with linking libssl.a and libcrypto.a static libraries which causes the build to fail.
|
Added changes that fixed Azure Pipeline Builds on MacOS since this is already a build-related pull request. The issue was with OpenSSL 1.0 being where OpenSSL 1.1.x should be symlinked (actions/runner-images#837) |
|
Thanks a lot! |
|
@p12tic @AdrianKoshka is no longer involved in this project from what I've been told. I still am though, so I'll approve these changes (they look good to me), then I'll merge them :) |
|
I am desperately waiting for a new build for Mac OS. The current release 2.3.2 isnt working actually on Catalina 10.15.5. I am not a developer and I do not know how to create builds. Your help is much appreciated here. :) |
|
@digantabanikya Just found where the azure builds are So that would be your best place |
|
Thank you. I will try. I have never seen what xcode looks like. lol |
|
You actually wont be looking at xcode at all. ANd if you just download the artifacts from https://dev.azure.com/debauchee/Barrier/_build/results?buildId=232&view=artifacts&type=publishedArtifacts you wont need xcode at all |
|
@plessbd Appreciate your patience in pointing things out to a rookie like me. I am no coder. I just see the published artifacts page but cant seem to download the packages on Mac/Windows. |
|
Piss Poor Design on Azures part Hover shows a ... that allows you to download |
|
@plessbd You're an angel. It worked! tested for 5 hours straight. Between Mac and Windows, Mac being the client. |
Making a release was failing with both Homebrew and MacPorts on Mojave. The compiled binary would run successfully, but the resulting
.appbundle from runningbuild_installer.sh(which runsreref_dylibs.shand builds the.appbundle) was giving SEGFAULT 11 when executed.This pull request replaces
build_installer.shwithbuild_dist.shthat runs the Qt toolkit'smacdeployqtwhich is included with the Qt on both MacPorts and Homebrew. It builds the distributable bundle and creates thedmgif it is a Release build.The previous scripts have been left in place with deprecation warnings in case they are still needed by older versions of MacOS.
It also removes the
ifcondition in CMake that prevents building a bundle on Debug releases.