Build documentation if not already built #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38ca8d0 to
357b0ff
Compare
Nemo157
reviewed
Nov 18, 2020
Nemo157
reviewed
Nov 18, 2020
1323492 to
5637b86
Compare
Nemo157
reviewed
Nov 19, 2020
c4b1617 to
92073be
Compare
- Test broken links with `cargo-deadlinks` The previous test depended that cargo-deadlinks wouldn't build the docs. To avoid that, I switched it to use `deadlinks` instead. But that meant there were no tests for `cargo-deadlinks`. Add a new test for the cargo version. - Add `no-build` to opt-out of running `cargo doc` - Update changelog
This also adds a `no_build` flag, prints errors on stderr instead of stdout, and no longer hides errors from cargo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11, fixes #38 as long as you don't pass
--no-build, fixes #99 as long as you don't pass--no-build.TODO: add better tests that can tell whether the documentation was rebuilt with
CARGO_TARGET_DIRset, otherwise it will definitely regress.