client: add peers restored message and improve error #1701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chappjc
commented
Jul 8, 2022
| newTip, err := dcr.getBestBlock(ctx) | ||
| if err != nil { | ||
| dcr.handleTipChange(nil, 0, fmt.Errorf("failed to get best block: %w", err)) | ||
| return |
There was a problem hiding this comment.
This return was the bug that resulted in "client has been shutdown" and unable to reconnect to the wallet without dexc restart. The defer cancel() was also not working as intended, plus it was filling up the defer stack leading to memory exhaustion.
chappjc
commented
Jul 12, 2022
Comment on lines
+1812
to
+1816
| // - overhead from 1 transaction | ||
| // - 1 extra signed p2wpkh-spending input. The split tx has the fundingCoins as | ||
| // inputs now, but we'll add the input that spends the sized coin that will go | ||
| // into the first swap if the split tx does not add excess baggage | ||
| // - 2 additional p2wpkh outputs for the split tx sized output and change |
There was a problem hiding this comment.
Hmm, I must have done go fmt with Go 1.19 rc1 which has new formatting. https://tip.golang.org/doc/go1.19#go-doc
Since older gofmt versions don't try to change it back, I think I'll leave it.
buck54321
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
monitorBlocks. The return was killing the wallet if connectivity was lost, instead of it being a temporary issue. This fixes those issues.