client/eth: Increase gas fee cap for redemptions when base fee is too high #1692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should go in before #1638. |
chappjc
reviewed
Jul 3, 2022
client/asset/eth/eth.go
Outdated
| } | ||
|
|
||
| // If our estimate is higher than the calculated limit | ||
| gasLimit := g.Redeem * n | ||
| var gasLimit, gasFeeCap uint64 = g.Redeem * n, form.FeeSuggestion |
There was a problem hiding this comment.
Shorthand is fine with this multiple assignment.
This diff increases the gas fee cap for redemptions to 2x base fee if the base fee > the fee suggestion. If the wallet does not have enough available funds for this, then the funds that are available will be used.
chappjc
approved these changes
Jul 12, 2022
JoeGruffins
approved these changes
Jul 12, 2022
| if err != nil { | ||
| return nil, nil, 0, fmt.Errorf("error getting redemption estimate: %v", err) | ||
| return nil, nil, 0, fmt.Errorf("error getting balance in excessive gas fee recovery: %v", err) |
There was a problem hiding this comment.
could use return fail(~error~)
| // funds we have available. | ||
| baseFee, _, err := w.node.currentFees(w.ctx) | ||
| if err != nil { | ||
| return fail(fmt.Errorf("Error getting net fee state: %w", err)) |
There was a problem hiding this comment.
Don't need to capitalize Error unless logging full sentences.
There was a problem hiding this comment.
Good points @JoeGruffins. Sorry to interrupt your review. @martonp can fold these revisions into #1638
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff increases the gas fee cap for redemptions to 2x base fee if the base fee > the fee suggestion. If the wallet does not have enough available funds for this, then the funds that are available will be used.