ui: Copy deposit address alert #1675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, I was actually looking out for this :). |
chappjc
reviewed
Jun 20, 2022
Comment on lines
238
to
239
| navigator.clipboard.writeText(page.depositAddress.textContent || '') | ||
| Doc.show(page.copyAlert) |
There was a problem hiding this comment.
We should only show the "Copied!" alert if writeText says it succeeded.
navigator.clipboard.writeText(textContent).then(() => {
Doc.show(page.copyAlert)
...
}, (reason) => {
console.error('Unable to copy:', reason) // or a different alert, whatever
})
It feels very unsatisfying to click it and have nothing happen haha. |
JoeGruffins
approved these changes
Jun 22, 2022
chappjc
approved these changes
Jun 22, 2022
| @@ -92,3 +92,9 @@ table.wallets { | |||
| cursor: pointer; | |||
| color: #a8a8a8; | |||
| } | |||
|
|
|||
| #copyAlert { | |||
| margin-left: 9px; | |||
There was a problem hiding this comment.
With 9px it's right up against the div for me. Maybe 12?
|
Oh, trivial conflict though. |
8c82eb9 to
337484a
Compare
Adds a disappearing message confirming that the deposit address has been copied.
337484a to
12dc2f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a disappearing message confirming that the deposit address has been copied.