client: fix client forever loading when connecting to off server #1647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeGruffins
approved these changes
Jun 7, 2022
| @@ -2228,7 +2228,7 @@ class MarketList { | |||
| /* exists will be true if the specified market exists. */ | |||
| exists (host: string, baseID: number, quoteID: number) { | |||
| const xc = this.xcSection(host) | |||
| if (!xc) return false | |||
| if (!xc || !xc.marketRows) return false | |||
There was a problem hiding this comment.
Could maybe use a comment as to why this is necessary so it doesn't get broken again in the future.
There was a problem hiding this comment.
Thanks for the review Joe, I added the comment.
There was a problem hiding this comment.
@JoeGruffins did you say you got an error on the wallets page too (as well as the markets page)? It looks like @martonp fixed that in 30e29d7#diff-1fb1a75f430311eb5c798880a2edbce5c4f529a823bd265bf255b3f4ba0cd8d9
71975fe to
a660411
Compare
chappjc
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1495