Skip to content

multi: check rpc semver compatibility #1645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 7, 2022
Merged

multi: check rpc semver compatibility #1645

merged 3 commits into from
Jun 7, 2022

Conversation

ukane-philemon
Copy link
Contributor

@ukane-philemon ukane-philemon commented Jun 2, 2022 •
edited
Loading

This adds new values to RPC server version return. Closes #1151

  • add dexc version to rpc server version return value
  • add supported RPC version to dexcctl.
  • change dexc RPC server version return to a json object
  • Edit: update rpc version handler test
$ ./dexcctl version
{
  "rpcServerVersion": {
    "Major": 0,
    "Minor": 2,
    "Patch": 0
  },
  "dexcVersion": {
    "versionString": "0.5.0-pre+9763b71bb",
    "major": 0,
    "minor": 5,
    "patch": 0,
    "prerelease": "pre",
    "buildMetadata": "9763b71bb.go1-18"
  }
}

$ ./dexcctl -V
dexcctl version 0.5.0-pre+9763b71bb (Go version go1.18 linux/amd64)
dexcctl required RPC server version: 0.2.0

ukane-philemon added 2 commits June 2, 2022 21:51
multi: check rpc semver compatibility
9763b71 
- add dexc version to rpc server version return value
- change dexc rpc server version return to a json object
update version handler test
f551863
JoeGruffins
JoeGruffins approved these changes Jun 7, 2022
View reviewed changes
Copy link
Member

@JoeGruffins JoeGruffins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect to me.

chappjc
chappjc requested changes Jun 7, 2022
View reviewed changes
Copy link
Member

@chappjc chappjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. A few minor things.

@chappjc chappjc merged commit 2b63a55 into decred:master Jun 7, 2022
@chappjc chappjc added this to the 0.5 milestone Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chappjc chappjc chappjc approved these changes

@JoeGruffins JoeGruffins JoeGruffins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5
Development

Successfully merging this pull request may close these issues.

dexcctl: Add supported rpc version.
3 participants
@ukane-philemon @chappjc @JoeGruffins