multi: Clear private data asap. #1584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeGruffins
commented
Apr 13, 2022
JoeGruffins
commented
Apr 13, 2022
chappjc
requested changes
Apr 15, 2022
There was a problem hiding this comment.
Thanks for this. I'm pretty sure we don't need the new encrypt.Zero given encode.ClearBytes.
I would not be opposed to dex/encrypt/encrypt.go defining type Zero = encode.ClearBytes to smooth some stuff out, but if a package is already importing dex/encode, there's really no need to use encrypt.
3cee718 to
85b65b7
Compare
|
Just rebased. |
In core methods and consumers, clear passwords, private keys, and seeds when possible to protect against some memory scraping attacks.
85b65b7 to
7ab5425
Compare
chappjc
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lightly discussed in #1582
This pr makes it so the crypter cannot be used in goroutines. I think we're not doing so atm, but should be careful going forward.