Skip to content

server/asset: Check if txindex is enabled. #1549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 12, 2022
Merged

server/asset: Check if txindex is enabled. #1549

merged 3 commits into from
Apr 12, 2022

Conversation

ukane-philemon
Copy link
Contributor

@ukane-philemon ukane-philemon commented Mar 26, 2022 •
edited
Loading

This diff:

  1. checks if -txindex is enabled for bitcoind
  2. checks if --txindex is enabled for dcrd.
    Closes server/dcr: Preemptively check for --txindex. #1535

@ukane-philemon ukane-philemon marked this pull request as ready for review March 29, 2022 14:58
chappjc
chappjc reviewed Mar 29, 2022
View reviewed changes
chappjc
chappjc requested changes Mar 30, 2022
View reviewed changes
@ukane-philemon ukane-philemon force-pushed the addgetinfo branch 2 times, most recently from bcac3e6 to bbd29a1 Compare March 31, 2022 06:41
chappjc
chappjc requested changes Apr 4, 2022
View reviewed changes
Copy link
Member

@chappjc chappjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One last logic clean up please

@ukane-philemon
Copy link
Contributor Author

@chappjc thanks for the review, all changes applied.

buck54321
buck54321 approved these changes Apr 6, 2022
View reviewed changes
@chappjc chappjc merged commit 0a243bd into decred:master Apr 12, 2022
@chappjc chappjc added this to the 0.5 milestone Apr 21, 2022
@chappjc chappjc mentioned this pull request Aug 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buck54321 buck54321 buck54321 approved these changes

@chappjc chappjc chappjc approved these changes

@JoeGruffins JoeGruffins JoeGruffins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5
Development

Successfully merging this pull request may close these issues.

server/dcr: Preemptively check for --txindex.
4 participants
@ukane-philemon @buck54321 @chappjc @JoeGruffins