start recognizing signatures of the hashed messages (sig fix stage 1) #1528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Working when rebased on release-v0.4 |
Update the FundingCoin.Auth implementations to accept signatures of a message that is either the truncated data (legacy clients) or a client-specific hash of the message. When we do the v0 purge (V0PURGE), the older buggy signatures should be rejected.
9ccbc2a to
5c4db49
Compare
buck54321
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is stage 1 of the signature message truncation fix plan outlined #1526.
In these commits, both client and server begin recognizing signatures of both the truncated messages or the message hash. Neither side begins signing the message hash. After this has been deployed to servers, the next stage (#1529) has the client begin creating signatures of the hashed messages.