update to Go 1.18 #1519
Merged
update to Go 1.18 #1519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73ae9ce to
1359037
Compare
|
Working now, but golangci-lint is still sorting out go 1.18 issues: golangci/golangci-lint#2649 (comment) |
JoeGruffins
approved these changes
Mar 22, 2022
This updates the go.mod files to go 1.17, the new minimum supported Go version. Update README for go 1.18. Remove all +build lines from go code since all supported Go versions understand //go:build lines.
- Go versions 1.17 and 1.18 - set token permissions for build.yml - update checkout and setup-go actions to v3 - golangci-lint 1.45.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates for Go 1.18.
The supported Go versions are now 1.17 and 1.18.
CI is updated to new action versions and uses golangci-lint v1.45.0.
All the old
//+buildlines are removed now that all supported Go versions understand the new//go:buildlines.The go.mod now specifies
go 1.17, and ago mod tidyis applied.