client/ui/btc: Configure wallet bday #1439

martonp · 2022-01-22T17:49:42Z

The wallet birthday for the bitcoin SPV wallet was previously
always set to a hardcoded value. This diff stores the time when
the app seed was generated in the db to give an earliest possible
time so scan from, and also adds options on the UI to specify the
desired wallet birthday. Also, the wallet birthday can now be updated
when reconfiguring the wallet

Closes #1270.

martonp · 2022-01-22T17:53:20Z

If fresh wallet is selected, the current time will be used for the birthday. If earliest possible is selected, if the seed generation time is stored, that time will be used, otherwise the hardcoded date will be used. If the custom date is selected, that date will be used unless either the seed generation time is or the hardcoded date is later.

buck54321 · 2022-01-25T21:33:09Z

This seems like exactly what WalletDefinition.ConfigOpts are for.

martonp · 2022-01-25T22:34:29Z

I was thinking the ConfigOpts were things that could change after the wallet has already been created, while this is something that is just needed for wallet creation. I guess it does make sense though to be able to update the wallet birthday and then do a rescan though.

JoeGruffins

Working well.

client/db/bolt/db.go

client/asset/driver.go

client/core/core.go

martonp · 2022-01-28T17:34:34Z

It's now using WalletDefinition.ConfigOpts . On the create wallet screen it looks the same as in the picture above, but when reconfiguring the wallet, there is just a regular date input. If the wallet is reconfigured with a new birthday, rescan will update the walletdb and use the new birthday.

client/asset/btc/spv.go

client/core/core.go

client/asset/btc/btc.go

chappjc · 2022-02-08T17:07:08Z

In testing, I hit an existing data race in ReconfigureWallet that I believe can be resolved as follows:

I'm gonna put this in a tiny PR so we can have it in 0.4.1

chappjc · 2022-02-22T15:22:56Z

Conflicts with QR code merged. Will review latest commit asap though.

buck54321

Just a couple of comments.

buck54321 · 2022-02-28T15:41:56Z

client/core/core.go

@@ -1896,6 +1909,17 @@ func (c *Core) WalletState(assetID uint32) *WalletState {
 	return wallet.state()
 }

+// AssetHasActiveOrders checks whether there are any active orders or
+// negotiating matches for the specified asset.
+func (c *Core) AssetHasActiveOrders(assetID uint32) bool {


OK, but the front-end has everything it needs for this already in the User object.

That reminds me, I had something similar in frontend for the rescan PR but we ended up moving into Core for the check. 3ab44ef Can use that JS or something like it if you want to move the logic to frontend.

This is a different use case of course, but here's the previous discussion: #1374 (comment)
I ended up agreeing that it made sense to check in Core, but I also appreciate that frontend can know too, even if its check might turn out to be stale, with Core ultimately blocking it.

Ohhhh, this method is double-purposed in apiWalletSettings as well as loadWallet. Yah, it could be omitted from the wallet setting response.

client/webserver/site/src/localized_html/en-US/forms.tmpl

chappjc · 2022-02-28T23:25:43Z

Silly conflict with btc.go.

chappjc

All working well. Just a few formatting and grammatical issues with the birthday config opt description.

client/asset/btc/btc.go

client/core/core.go

client/webserver/locales/en-us.go

client/webserver/site/src/html/forms.tmpl

client/asset/btc/btc.go

client/asset/btc/spv.go

buck54321 · 2022-03-02T12:00:00Z

client/asset/interface.go

+	IsBoolean         bool        `json:"isboolean"`
+	IsDate            bool        `json:"isdate"`
+	DisableWhenActive bool        `json:"disablewhenactive"`
+	IsBirthdayConfig  bool        `json:"isBirthdayConfig"`


Instead of a separate field, how about just handle a special DefaultValue "now" or "birthday" like you did with the min and max values.

if (opt.isdate && opt.default === 'now')

The behavior I wanted on the UI was to have the default value be "now" if the current installation created the seed, but otherwise be the default value passed in the config.

client/asset/btc/spv.go

client/core/core.go

client/webserver/site/src/localized_html/en-US/bodybuilder.tmpl

chappjc · 2022-03-04T17:41:33Z

can merge, but I made conflicts

The wallet birthday for the bitcoin SPV wallet was previously always set to a hardcoded value. This diff stores the time when the app seed was generated in the db to give an earliest possible time so scan from, and also adds options on the UI to specify the desired wallet birthday. Also, the wallet birthday can now be updated when reconfiguring the wallet.

JoeGruffins reviewed Jan 26, 2022

View reviewed changes

client/db/bolt/db.go Outdated Show resolved Hide resolved

client/asset/driver.go Outdated Show resolved Hide resolved

client/core/core.go Outdated Show resolved Hide resolved

martonp force-pushed the walletBday branch from 966c813 to 8c7e05f Compare January 28, 2022 17:28

martonp changed the title ~~client/ui/btc: More accurate wallet bday~~ client/ui/btc: Configure wallet bday Jan 28, 2022

martonp force-pushed the walletBday branch from 8c7e05f to 5378db4 Compare January 28, 2022 17:31

martonp force-pushed the walletBday branch from 5378db4 to aa52c26 Compare January 28, 2022 17:35

chappjc reviewed Jan 28, 2022

View reviewed changes

client/asset/btc/spv.go Show resolved Hide resolved

chappjc reviewed Jan 31, 2022

View reviewed changes

client/core/core.go Show resolved Hide resolved

chappjc reviewed Jan 31, 2022

View reviewed changes

client/asset/btc/btc.go Outdated Show resolved Hide resolved

This comment was marked as resolved.

Sign in to view

chappjc mentioned this pull request Feb 8, 2022

client/core: fix data race in ReconfigureWallet #1470

Merged

chappjc requested a review from buck54321 February 9, 2022 19:18

martonp force-pushed the walletBday branch 2 times, most recently from 4720cc9 to a468245 Compare February 22, 2022 15:35

chappjc self-requested a review February 24, 2022 17:04

buck54321 reviewed Feb 28, 2022

View reviewed changes

martonp force-pushed the walletBday branch from 2e2c943 to 3d7963a Compare February 28, 2022 22:43

chappjc mentioned this pull request Feb 28, 2022

client/ui: Display registration tx fee estimate #1444

Merged

chappjc requested changes Mar 1, 2022

View reviewed changes

buck54321 requested changes Mar 2, 2022

View reviewed changes

martonp force-pushed the walletBday branch 3 times, most recently from 9498976 to 97e966a Compare March 3, 2022 22:03

buck54321 approved these changes Mar 4, 2022

View reviewed changes

martonp added 6 commits March 4, 2022 14:19

Update cache buster

004cd64

Update spvWallet.birthday when doing rescan

61ccbce

Automatic rescans and block bday update if there are active orders

b662345

Use regular date input and check active deals in UI

9f728d9

Updates based on review

791dcb6

martonp force-pushed the walletBday branch from 97e966a to 791dcb6 Compare March 4, 2022 19:25

chappjc approved these changes Mar 4, 2022

View reviewed changes

chappjc merged commit 32721d8 into decred:master Mar 4, 2022

chappjc added this to the 0.5 milestone Apr 21, 2022

martonp deleted the walletBday branch December 20, 2022 22:09

client/ui/btc: Configure wallet bday #1439

client/ui/btc: Configure wallet bday #1439

Uh oh!

Conversation

martonp commented Jan 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

martonp commented Jan 22, 2022

Uh oh!

buck54321 commented Jan 25, 2022

Uh oh!

martonp commented Jan 25, 2022

Uh oh!

JoeGruffins left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

martonp commented Jan 28, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

chappjc commented Feb 8, 2022

Uh oh!

chappjc commented Feb 22, 2022

Uh oh!

buck54321 left a comment

Choose a reason for hiding this comment

Uh oh!

buck54321 Feb 28, 2022

Choose a reason for hiding this comment

Uh oh!

chappjc Feb 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chappjc Feb 28, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chappjc commented Feb 28, 2022

Uh oh!

chappjc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

buck54321 Mar 2, 2022

Choose a reason for hiding this comment

Uh oh!

martonp Mar 2, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chappjc commented Mar 4, 2022

Uh oh!

Uh oh!

martonp commented Jan 22, 2022 •

edited

Loading

chappjc Feb 28, 2022 •

edited

Loading