eth: compare parsed address in OwnsAddress #1306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The string address can have different formattings, so parse the input string into a common.Address and compare that to the account address. Also use direct array comparison for address equality instead of bytes.Equal.
4826b96 to
fb45006
Compare
chappjc
commented
Nov 17, 2021
Comment on lines
+340
to
+343
| if !common.IsHexAddress(address) { | ||
| return false, errors.New("invalid address") | ||
| } | ||
| addr := common.HexToAddress(address) |
There was a problem hiding this comment.
common.NewMixedCaseAddress would work fine for this too, but it has a little extra overhead we don't need
JoeGruffins
approved these changes
Nov 19, 2021
buck54321
approved these changes
Nov 26, 2021
|
Thank you. I saw the same SignMessage receiver change in #1301 , which I have been reviewing today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The string address can have different formattings, so parse the input string into a
common.Addressand compare that to the account address. For example, it can be formatted with mixed case and with or without "0x", among other things.Also use direct array comparison for address equality instead of
bytes.Equal.Also address some missing error checks.