server,eth: add method for account balance retrieval #1284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeGruffins
approved these changes
Nov 11, 2021
|
Needs resolve after txData PR merged. Might as well squash down with a final commit too. |
3c5355f to
a5d605d
Compare
chappjc
reviewed
Nov 15, 2021
| // accountBalance gets the account balance, including the effects of known | ||
| // unmined transactions. | ||
| func (c *rpcclient) accountBalance(ctx context.Context, addr common.Address) (*big.Int, error) { | ||
| bigBal, err := c.ec.PendingBalanceAt(ctx, addr) |
There was a problem hiding this comment.
I wonder how this works with multiple txns in txpool with the same nonce, e.g. replacements commonly used to either cancel a txn or speed up a txn
There was a problem hiding this comment.
cancel a txn
How would that work? Like maybe send it to yourself instead? Or I guess could put the amount to zero?
There was a problem hiding this comment.
Exactly, a 0 ETH transaction to yourself with the same nonce as the txn to be canceled but higher fees. At least that's how I've seen it on etherscan.
Moves FundingCoin and VerifyUnspentCoin to a new interface called OutputTracker. A different interface called AccountBalancer will be used for eth and other "account-based" assets.
a5d605d to
05b8d97
Compare
chappjc
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interfaces are going to need to diverge when it comes to tracking funding ability. This PR is a first thrust at a reasonable interface scheme so that we can begin work in
Swapper,Market, andCoinLocker.