Skip to content

btc: wallet history classifies Swap transaction type incorrectly #3137

@norwnd

Description

@norwnd

I've noticed Bitcoin SPV wallet history has a bug:

image

namely it seems to be classifying Swap as Refund, while not showing the actual Refund transaction that is currently in mempool - you can see on screenshot above:

  1. I received funds and then
  2. there is a Refund without any prior Swap (there is Acceleration transaction I've issued after swap has been stuck for some time, and that's what got Swap transaction mined couple of hours later - but at that point Match was revoked and it switched to refunding flow as it should)

Match-card page shows all 3 transactions (Swap tx, separate Acceleration tx, pending Refund tx) correctly.

After browsing through the relevant code I'm thinking this adjustment should resolve the issue (it relaxes the requirement on Swap/Send transactions to have tx.Send == true and looks like this is how it's done for zcash as well)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions