Skip to content

ui: mm bot notification handling exception (when bot is not ready yet)  #3100

@norwnd

Description

@norwnd

I've noticed the following exception thrown in JS console:

image

it seems the following notification handler runs even before MM bot can handle it (has proper market set up on it):

      runstats: (note: RunStatsNote) => {
        this.mm.update()
        if (note.baseID !== this.market.base.id || note.quoteID !== this.market.quote.id || note.host !== this.market.dex.host) return
        if (Boolean(this.mmRunning) !== Boolean(note.stats)) {
          this.mmRunning = Boolean(note.stats)
          this.resolveOrderFormVisibility()
        }
      },

doesn't seem like that leads to any problems in practice, but

  • perhaps we might miss some important notification(s) this way causing mm bot UI widget to get stuck until page is refreshed or something
  • keeping console log clean would help when debugging other issues

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions