Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: decred/dcrdex
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.6.1
Choose a base ref
...
head repository: decred/dcrdex
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.6.2
Choose a head ref
  • 11 commits
  • 47 files changed
  • 4 contributors

Commits on Jun 14, 2023

  1. Configuration menu
    Copy the full SHA
    b9c9ece View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. asset: Implement asset.FeeRater for SPV wallets and minor refactor

    Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
    ukane-philemon authored and chappjc committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    89e761a View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. Configuration menu
    Copy the full SHA
    3622872 View commit details
    Browse the repository at this point in the history
  2. btc: more sensible bond fee buffer

    When used for computing the bond fee buffer, the "fee rate limit" makes
    an extremely hight fee rate buffer, which makes BTC bonds impractical.
    This change:
    - switches to using a dynamic fee rate with the configured fallback rate
      for both ReserveBondFunds and BondsFeeBuffer, where the former is
      used as the requirement for the frontend to proceed with registration
    - uses the exported BondsFeeBuffer method when automatically creating
      the "extra" split output in certain order funding edge cases instead
      of a buffer based on the high limit.
    - tweaks the bond tx input count to be slightly less conservative, going
      from 12 -> 8 possible inputs
    - gives BondsFeeBuffer a fee rate parameter so that a rate can come from
      Core even if the wallet has no estimate source
    - give ReserveBondFunds a feeBuffer paramerter so that the buffer used
      during wallet funding (from BondsFeeBuffer) can be used, preventing
      possible bad UX if the fee rates go up and they have to send more.
    
    The motivation for these changes is that using the wallet's configure
    fee rate limit create extremely high fee bufferes, whereas we have
    defined the "fallback" fee rate to be a reasonable fallback where a
    current estimate is not available.
    
    Further, this is a buffer and precision is not critical, but turning
    users away from onboarding is a major issue.  The right approach
    is to base reserves on a padded estimate based on current rates,
    not the swap fee rate limit.
    
    Finally, given this softening of the reserves amount, no adjustment to
    the enforced bond reserves in Reconfigure is done since we are now
    using current rates as a hit of future rates.
    
    Padding of this fee buffer already comes from:
    - planning for a lot of inputs
    - 4 parallel bond tracks
    - the exported BondsFeeBuffer method doubling the provided fee rate
    
    Even if fee rates skyrocket, and the reserves become insufficient for
    bond renewal, the user will still post bond if their balance allows, and
    they may deposit some nominal additional amount to cover any such
    deficit.
    chappjc committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    300e975 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3957ff7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b1b75a2 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2023

  1. Configuration menu
    Copy the full SHA
    8aad3fa View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9908805 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2023

  1. site: bond asset choice wording tweaks and settings page fixes

    This tweaks the wording on the bond asset selection form and adds the
    "whatsabond" information text.
    
    This also fixes a bug where the settings page was using the old registration fee
    instead of the "bonds fee buffer".  It also fixes the condition for skipping the
    wallet balance wait form created from the settings page.
    
    ---------
    
    Co-authored-by: buck54321 <buck54321@gmail.com>
    chappjc and buck54321 committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    29faa9b View commit details
    Browse the repository at this point in the history
  2. v0.6.2

    chappjc committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    167592c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e0c0c8e View commit details
    Browse the repository at this point in the history
Loading