Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: decred/dcrdex
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.5.7
Choose a base ref
...
head repository: decred/dcrdex
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.5.8
Choose a head ref
  • 6 commits
  • 19 files changed
  • 2 contributors

Commits on Dec 15, 2022

  1. client: check for zero fiat rates and response status code 

    This increases the request interval for fiat rates to 12min due to a
possibility of hitting source's request limits. This can be considered a
temporary solution since we need to adjust this interval for every added
asset.

This also checks the HTTP response status code instead of assuming
the response is the expected payload.
    @ukane-philemon @chappjc
    ukane-philemon authored and chappjc committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    2ae50bb View commit details
    Browse the repository at this point in the history

  2. client/{core,db}: options for core startup/shutdown 

    This adds two new core.Config options aimed at improving startup
and shutdown depending on the user's use case:
 - NoAutoWalletLock instructs Core to skip locking the wallet on
   shutdown. This can be helpful if the user wants the wallet to remain
   unlocked. e.g. They started with the wallet unlocked, or they intend
   to start Core again and wish to avoid the time to unlock a locked
   wallet on startup.
 - NoAutoDBBackup instructs the DB to skip the creation of a backup DB
   file on shutdown. This is useful if the consumer is using the
   BackupDB method, or simply creating manual backups of the DB file
   after shutdown.

These options are intended for direct Core consumers, such as headless
applications that drive Core directly instead of via the browser UI.

These options are created so that the zero-value corresponds to legacy
behavior. That is, the defaults are the existing behavior. However, in
client/db/bolt, the BackupOnShutdown is reversed from Core's
NoAutoDBBackup flag. The NewDB constructor accepts an optional db.Opts
struct, and if it is not provided, a defaultOpts is used that has
BackupOnShutdown set to true.
    @chappjc
    chappjc committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    c35709c View commit details
    Browse the repository at this point in the history

  3. client/{asset,core}: add UnlockCoinsOnLogin option 

    This adds the core.Config.UnlockCoinsOnLogin option that indicates that
on wallet connect during login, or on creation of a new wallet, all
coins with the wallet should be unlocked.

To support this "unlock all" with the wallets, the ReturnCoins method
of the asset.Wallet interface now interprets a nil Coins slice to mean
that all coins should be unlocked. This is similar to the lockunspent
RPC's semantics.

The individual implementations of ReturnCoins are modified to recognize
a nil unspent input slice and accordingly request the wallet backend
unlock all coins.
    @chappjc
    chappjc committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    9870a0c View commit details
    Browse the repository at this point in the history

  4. client/cmd/dexc: add args for core opt 

          --no-wallet-lock        Disable locking of wallets on shutdown.
      Use this if you want your external wallets to stay unlocked after
      closing the DEX app.
      --no-db-backup          Disable creation of a database backup on
      shutdown.
      --release-wallet-coins  On login or wallet creation, instruct the
      wallet to release any coins that it may have locked.
    @chappjc
    chappjc committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    46f5489 View commit details
    Browse the repository at this point in the history

  5. build with a supported Go version

    @chappjc
    chappjc committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    52ab402 View commit details
    Browse the repository at this point in the history

  6. v0.5.8

    @chappjc
    chappjc committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    70241d0 View commit details
    Browse the repository at this point in the history
Loading