Skip to content

Fix relation control loading values #7556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2025
Merged

Conversation

demshy
Copy link
Member

@demshy demshy commented Jul 22, 2025

Summary
Seems like async function does not play nice with debounce after the caching update we did in 3.8. This is a patch that fixes this by using promise chaining again.

Test plan

Checklist

Please add a x inside each checkbox:

A picture of a cute animal (not mandatory but encouraged)

@demshy demshy requested a review from a team as a code owner July 22, 2025 08:26
@github-actions github-actions bot added the type: bug code to address defects in shipped code label Jul 22, 2025
@demshy demshy requested review from Copilot and martinjagodic and removed request for a team July 22, 2025 08:27
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue with the relation control widget where async function behavior conflicts with debounce functionality after a caching update in version 3.8. The solution changes the implementation from async/await syntax back to promise chaining within the debounced function.

Key Changes

  • Converts loadOptions method from async/await to promise chaining to resolve debounce compatibility issues
  • Removes try/catch error handling block as part of the refactor

@martinjagodic martinjagodic enabled auto-merge (squash) July 22, 2025 08:34
@martinjagodic martinjagodic merged commit 0c191ed into main Jul 22, 2025
14 checks passed
@martinjagodic martinjagodic deleted the fix/relation-control-7546 branch July 22, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants