refactor: only use regex for matching markdown widgets #7529
+214
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The main problem I see is with patterns which do not begin with See, remark goes through the markdown document and cuts off what has already been matched. Multiline pattern without Decap could strongly require matching Instead, it could check the pattern and ignore matches which are not at the beginning of the remaining markdown value. I would need to think about possible edge cases. |
9411948 to
2d5acb4
Compare
demshy
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Starting this to hopefully fix #5065
Test plan
I found that the tests of
remarksShortcodesare very isolated and completely stub out remark. I don't think that's appropriate and they should instead use a more realistic scenario, using remark and test widgets. More verbose, a not "unit" anymore but I think that method will be more robust in simulating actual usage scenario. Current tests actually ignore how remark works so it's easy to create passing tests of code which does not work in practiceChecklist
Please add a
xinside each checkbox: