Skip to content

Conversation

shadow-light
Copy link

Summary

Correct type for pattern property

Checklist

@netlify
Copy link

netlify bot commented Jun 6, 2023

Deploy Preview for decap-www ready!

Name Link
🔨 Latest commit 339a4ab
🔍 Latest deploy log https://app.netlify.com/sites/decap-www/deploys/647e7ced5ebcc5000779842b
😎 Deploy Preview https://deploy-preview-6794--decap-www.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@martinjagodic martinjagodic requested a review from demshy June 6, 2023 05:36
@martinjagodic
Copy link
Member

@shadow-light can you please solve the merge conflict? It appeared because packages and folders were renamed.

Also, what is the motivation behind this PR? Where did this cause a problem?

@xaiki
Copy link

xaiki commented Oct 4, 2023

this looks correct, but there are many other places where pattern is either string or Regex, they should probably all be string | RegExp

kyoshino added a commit to sveltia/sveltia-cms that referenced this pull request Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants