Skip to content

Conversation

cccs-jh
Copy link
Contributor

@cccs-jh cccs-jh commented Feb 13, 2024

The imp module is removed in 3.12 and causes an error when loading xxxswf. The recommended replacement is importlib but here the use of imp is actually redundant. When yara isn't found the import yara statement already throws an ImportError for 3.5 and earlier, and for 3.6 and later it throws a ModuleNotFoundError which is a subclass of ImportError and is caught by the same try catch.

@decalage2 decalage2 self-requested a review February 13, 2024 10:45
@decalage2 decalage2 self-assigned this Feb 13, 2024
@decalage2 decalage2 added this to the oletools 0.60 milestone Feb 13, 2024
@hugovk
Copy link

hugovk commented Jun 7, 2024

This will fix #813.

@decalage2 decalage2 merged commit f053aad into decalage2:master Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants