Support for multiple duplicate keys in the QS of the url #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i think all the recently issues is about the query. we should add qs package to handle all of that maybe. |
|
I'm not sure incorporating the "qs" package would solve this particular issue, but thanks for merging 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier i fixed #28, which adds support for multiple values in the data parameter (the body of the request).
This pull request adds support for multiple duplicate keys in the QS of the url.
For example:
?formkey=formvalue1&formkey=formvalue2
This couldn't be signed properly earlier, and with this pull request, it can :)
Added unit test which tests this specific behavior.