Skip to content

build: move to goccy/go-yaml instead of yaml.v3, fixes #7280 #7281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

build: move to goccy/go-yaml instead of yaml.v3, fixes #7280 #7281

wants to merge 3 commits into from

Conversation

rfay
Copy link
Member

@rfay rfay commented May 9, 2025

The Issue

The long-painful yaml.v3 has finally been archived, we need to move on

How This PR Solves The Issue

Mostly move to goccy/go-yaml

It still has a couple of things:

$ go mod why gopkg.in/yaml.v3
# gopkg.in/yaml.v3
github.com/ddev/ddev/pkg/testcommon
github.com/stretchr/testify/assert
github.com/stretchr/testify/assert/yaml
gopkg.in/yaml.v3

According to

testify/assert can use a pluggable library, and there are references to it, but I didn't have the patience to understand what to do. And using in tests is not that big a problem.

Manual Testing Instructions

I don't think there's anything that needs to be done.

@github-actions github-actions bot added dependencies Pull requests that update a dependency file maintenance labels May 9, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2025

Download the artifacts for this pull request:

See Testing a PR.

Open in GitHub Codespaces

@rfay
Copy link
Member Author

rfay commented May 9, 2025

goccy/go-yaml interprets database version 8.0 (which we currently have unquoted) as a float, so we get mysql:8 instead of mysql:8.0.

Tests are great. Solving this, not so much.

This was referenced May 12, 2025
Closed
Closed
@rfay
Copy link
Member Author

rfay commented May 12, 2025

Related:

@rfay
Copy link
Member Author

rfay commented May 12, 2025

I think we'll want to try github.com/yaml/go-yaml as a future for this.

@rfay rfay closed this May 12, 2025
@rfay rfay deleted the 20250509_rfay_new_go_yaml branch July 22, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rfay