Skip to content

fix: make ddev describe work correctly with new Docker Desktop, for docker/for-mac#7742 #7531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2025
Merged

fix: make ddev describe work correctly with new Docker Desktop, for docker/for-mac#7742 #7531

merged 1 commit into from
Aug 18, 2025

Conversation

rfay
Copy link
Member

@rfay rfay commented Aug 15, 2025 •
edited
Loading

The Issue

Docker Desktop changed their internal inspect format, breaking ddev describe and TestCmdDescribe

How This PR Solves The Issue

Use the (appropriate) ExposedPorts to get the full set of exposed ports, instead of inferring it from Ports.

This affects only ddev describe and any other usages of app.Describe(), probably unlikely. It works on all the other Docker providers without problems.

We probably can't update our Docker Desktop runners (macOS and Windows) until this goes in, so manual testing is required with DD.

Manual Testing Instructions

With Docker Desktop 4.44.0:

  1. Use docker-compose.extra.yaml like this and ddev describe should show the 11111 ports etc.
services:
  web:
    expose:
      - 11111/tcp
      - 11112/tcp
      - 11113
  1. run TestCmdDescribe and it should succeed

Automated Testing Overview

No changes required as the original tests caught this problem in the first place.

Release/Deployment Notes

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 15, 2025 •
edited
Loading

Download the artifacts for this pull request:

See Testing a PR.

Open in GitHub Codespaces

@rfay rfay force-pushed the 20250815_rfay_describe_exposed branch from aebe418 to af886ca Compare August 15, 2025 16:22
@rfay rfay marked this pull request as ready for review August 15, 2025 18:18
@rfay rfay requested a review from a team as a code owner August 15, 2025 18:18
@rfay rfay requested a review from stasadev August 15, 2025 18:18
stasadev
stasadev approved these changes Aug 18, 2025
View reviewed changes
Copy link
Member

@stasadev stasadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@rfay rfay merged commit 43bc29f into ddev:main Aug 18, 2025
28 checks passed
@rfay rfay deleted the 20250815_rfay_describe_exposed branch August 18, 2025 13:45
@rfay
Copy link
Member Author

rfay commented Aug 18, 2025

Now that this is pulled we can upgrade Docker Desktop on buildkite runners. I'll try to do this when not much testing is going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stasadev stasadev stasadev approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rfay @stasadev