-
-
Notifications
You must be signed in to change notification settings - Fork 2
Comparing changes
Open a pull request
base repository: ddddddO/packemon
base: v1.7.0
head repository: ddddddO/packemon
compare: v1.7.1
- 17 commits
- 5 files changed
- 3 contributors
Commits on May 26, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 2b3e28a - Browse repository at this point
Copy the full SHA 2b3e28aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 857f5a8 - Browse repository at this point
Copy the full SHA 857f5a8View commit details
Commits on May 27, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 1390d4f - Browse repository at this point
Copy the full SHA 1390d4fView commit details
Commits on May 28, 2025
-
Configuration menu - View commit details
-
Copy full SHA for d4356e3 - Browse repository at this point
Copy the full SHA d4356e3View commit details -
fix: Support both hex and colon-separated MAC address formats in inpu…
…t fields - Increased MAC address input field width from 14 to 20 characters - Added support for colon-separated format (e.g., 3c:58:5d:55:77:0e) - Maintains support for hex format (e.g., 0x3c585d55770e) - Updated parsing logic to handle both formats correctly Fixes #96
Configuration menu - View commit details
-
Copy full SHA for 8c34235 - Browse repository at this point
Copy the full SHA 8c34235View commit details
Commits on May 29, 2025
-
fix: Address feedback on MAC address input handling
- Remove unnecessary comments that duplicate code logic - Fix issue where alphabetic characters couldn't be entered when field is empty - Now only attempts parsing when input length suggests a complete MAC address - Maintains support for both hex (0x prefix) and colon-separated formats Addresses feedback on PR #147
Configuration menu - View commit details
-
Copy full SHA for 7f34c9f - Browse repository at this point
Copy the full SHA 7f34c9fView commit details -
refactor: Remove redundant empty check in MAC address validation
- Removed unnecessary empty check condition from both MAC address fields - The empty input is already handled by the parsing logic - Makes the code cleaner and more concise
Configuration menu - View commit details
-
Copy full SHA for 57decf6 - Browse repository at this point
Copy the full SHA 57decf6View commit details -
refactor: Extract MAC address validation into helper function with tests
- Created validateAndParseMACAddress() helper function to eliminate code duplication - Added comprehensive unit tests covering valid/invalid formats and edge cases - Tests include hex format, colon-separated format, partial inputs, and error cases - Improves code maintainability and makes validation logic reusable Addresses code review suggestions for better code organization
Configuration menu - View commit details
-
Copy full SHA for c6b4e1c - Browse repository at this point
Copy the full SHA c6b4e1cView commit details -
feat: Add user feedback and dash format support for MAC addresses
- Added visual feedback for MAC address validation errors - Error messages appear below input fields in red - Success messages appear in green for valid addresses - Added support for dash-separated format (e.g., 3c-58-5d-55-77-0e) - Enhanced validation to show specific error reasons - Updated tests to cover new dash format and error messages - Improved character validation with specific invalid character feedback Now supports three MAC address formats: - Hex with 0x prefix: 0x3c585d55770e - Colon-separated: 3c:58:5d:55:77:0e - Dash-separated: 3c-58-5d-55-77-0e
Configuration menu - View commit details
-
Copy full SHA for 078729e - Browse repository at this point
Copy the full SHA 078729eView commit details -
fix: Fix build error with HardwareAddr nil comparison
- Changed validation result to use HasAddress boolean field - Since HardwareAddr is an array type [6]uint8, it cannot be compared to nil - Updated tests to use HasAddress instead of checking for nil - Fixed proper copying of bytes to HardwareAddr array This addresses the build error reported in PR #147 review
Configuration menu - View commit details
-
Copy full SHA for a5545c1 - Browse repository at this point
Copy the full SHA a5545c1View commit details -
Update internal/tui/generator/form_ethernet.go
Co-authored-by: Ochi Daiki <lbfdeatq@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8f89a0c - Browse repository at this point
Copy the full SHA 8f89a0cView commit details -
Update internal/tui/generator/form_ethernet.go
Co-authored-by: Ochi Daiki <lbfdeatq@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2a3d07a - Browse repository at this point
Copy the full SHA 2a3d07aView commit details -
fix: Remove custom color settings from Ethernet form for UI consistency
- Removed black background and white text color settings - Form now uses default blue background like other forms - Removed unused tcell import after color settings removal
Configuration menu - View commit details
-
Copy full SHA for 9f5b566 - Browse repository at this point
Copy the full SHA 9f5b566View commit details -
Configuration menu - View commit details
-
Copy full SHA for 145fa76 - Browse repository at this point
Copy the full SHA 145fa76View commit details -
chore: Remove CHANGELOG.md from repository
CHANGELOG.md is now in .gitignore and should not be tracked
Configuration menu - View commit details
-
Copy full SHA for 218130f - Browse repository at this point
Copy the full SHA 218130fView commit details -
Merge pull request #147 from cluster2600/main
fix: Support both hex and colon-separated MAC address formats in inpu…
Configuration menu - View commit details
-
Copy full SHA for 8868b13 - Browse repository at this point
Copy the full SHA 8868b13View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8090d4b - Browse repository at this point
Copy the full SHA 8090d4bView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.7.0...v1.7.1