Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ddddddO/packemon
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.7.0
Choose a base ref
...
head repository: ddddddO/packemon
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.7.1
Choose a head ref
  • 17 commits
  • 5 files changed
  • 3 contributors

Commits on May 26, 2025

  1. up

    ddddddO committed May 26, 2025
    Configuration menu
    Copy the full SHA
    2b3e28a View commit details
    Browse the repository at this point in the history
  2. up

    ddddddO committed May 26, 2025
    Configuration menu
    Copy the full SHA
    857f5a8 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2025

  1. up

    ddddddO committed May 27, 2025
    Configuration menu
    Copy the full SHA
    1390d4f View commit details
    Browse the repository at this point in the history

Commits on May 28, 2025

  1. up

    ddddddO committed May 28, 2025
    Configuration menu
    Copy the full SHA
    d4356e3 View commit details
    Browse the repository at this point in the history
  2. fix: Support both hex and colon-separated MAC address formats in inpu…

    …t fields
    
    - Increased MAC address input field width from 14 to 20 characters
    - Added support for colon-separated format (e.g., 3c:58:5d:55:77:0e)
    - Maintains support for hex format (e.g., 0x3c585d55770e)
    - Updated parsing logic to handle both formats correctly
    
    Fixes #96
    cluster2600 committed May 28, 2025
    Configuration menu
    Copy the full SHA
    8c34235 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2025

  1. fix: Address feedback on MAC address input handling

    - Remove unnecessary comments that duplicate code logic
    - Fix issue where alphabetic characters couldn't be entered when field is empty
    - Now only attempts parsing when input length suggests a complete MAC address
    - Maintains support for both hex (0x prefix) and colon-separated formats
    
    Addresses feedback on PR #147
    cluster2600 committed May 29, 2025
    Configuration menu
    Copy the full SHA
    7f34c9f View commit details
    Browse the repository at this point in the history
  2. refactor: Remove redundant empty check in MAC address validation

    - Removed unnecessary empty check condition from both MAC address fields
    - The empty input is already handled by the parsing logic
    - Makes the code cleaner and more concise
    cluster2600 committed May 29, 2025
    Configuration menu
    Copy the full SHA
    57decf6 View commit details
    Browse the repository at this point in the history
  3. refactor: Extract MAC address validation into helper function with tests

    - Created validateAndParseMACAddress() helper function to eliminate code duplication
    - Added comprehensive unit tests covering valid/invalid formats and edge cases
    - Tests include hex format, colon-separated format, partial inputs, and error cases
    - Improves code maintainability and makes validation logic reusable
    
    Addresses code review suggestions for better code organization
    cluster2600 committed May 29, 2025
    Configuration menu
    Copy the full SHA
    c6b4e1c View commit details
    Browse the repository at this point in the history
  4. feat: Add user feedback and dash format support for MAC addresses

    - Added visual feedback for MAC address validation errors
    - Error messages appear below input fields in red
    - Success messages appear in green for valid addresses
    - Added support for dash-separated format (e.g., 3c-58-5d-55-77-0e)
    - Enhanced validation to show specific error reasons
    - Updated tests to cover new dash format and error messages
    - Improved character validation with specific invalid character feedback
    
    Now supports three MAC address formats:
    - Hex with 0x prefix: 0x3c585d55770e
    - Colon-separated: 3c:58:5d:55:77:0e
    - Dash-separated: 3c-58-5d-55-77-0e
    cluster2600 committed May 29, 2025
    Configuration menu
    Copy the full SHA
    078729e View commit details
    Browse the repository at this point in the history
  5. fix: Fix build error with HardwareAddr nil comparison

    - Changed validation result to use HasAddress boolean field
    - Since HardwareAddr is an array type [6]uint8, it cannot be compared to nil
    - Updated tests to use HasAddress instead of checking for nil
    - Fixed proper copying of bytes to HardwareAddr array
    
    This addresses the build error reported in PR #147 review
    cluster2600 committed May 29, 2025
    Configuration menu
    Copy the full SHA
    a5545c1 View commit details
    Browse the repository at this point in the history
  6. Update internal/tui/generator/form_ethernet.go

    Co-authored-by: Ochi Daiki <lbfdeatq@gmail.com>
    cluster2600 and ddddddO authored May 29, 2025
    Configuration menu
    Copy the full SHA
    8f89a0c View commit details
    Browse the repository at this point in the history
  7. Update internal/tui/generator/form_ethernet.go

    Co-authored-by: Ochi Daiki <lbfdeatq@gmail.com>
    cluster2600 and ddddddO authored May 29, 2025
    Configuration menu
    Copy the full SHA
    2a3d07a View commit details
    Browse the repository at this point in the history
  8. fix: Remove custom color settings from Ethernet form for UI consistency

    - Removed black background and white text color settings
    - Form now uses default blue background like other forms
    - Removed unused tcell import after color settings removal
    cluster2600 committed May 29, 2025
    Configuration menu
    Copy the full SHA
    9f5b566 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    145fa76 View commit details
    Browse the repository at this point in the history
  10. chore: Remove CHANGELOG.md from repository

    CHANGELOG.md is now in .gitignore and should not be tracked
    cluster2600 committed May 29, 2025
    Configuration menu
    Copy the full SHA
    218130f View commit details
    Browse the repository at this point in the history
  11. Merge pull request #147 from cluster2600/main

    fix: Support both hex and colon-separated MAC address formats in inpu…
    ddddddO authored May 29, 2025
    Configuration menu
    Copy the full SHA
    8868b13 View commit details
    Browse the repository at this point in the history
  12. up

    ddddddO committed May 29, 2025
    Configuration menu
    Copy the full SHA
    8090d4b View commit details
    Browse the repository at this point in the history
Loading