-
Notifications
You must be signed in to change notification settings - Fork 363
Various minor cleanups and improvements #719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the documentation for `vars`: > NOTE: For use with variables in the current package for a single > scope, the functionality provided by this pragma has been superseded > by "our" declarations, available in Perl v5.6.0 or later, and use of > this pragma is discouraged.
It's better to start a test HTTP server or override `@curl` from tests in `t/*.pl`.
This makes log messages easier to understand.
This is simpler, and makes it possible to distinguish unset from set to an empty string.
The same message is already logged in `get_ipv4`.
Why issue a warning that things have suddenly started going well? It's bizarre.
Before, the first line of a multi-line log message was prefixed with a space while all subsequent messages were prefixed with `|`. Now the first line is prefixed with `>` and all subsequent lines with a space. This makes it easier to quickly discern message boundaries.
5b3a700
to
68fa2ab
Compare
The non-destructive substitution modifier wasn't added until Perl v5.14.0.
`geturl` already debug logs the response.
`header_ok` already checks for non-2xx codes.
`header_ok` already checks whether the response is `undef`.
for readability.
It's already initialized to a non-success value.
This also makes it possible to change "ipv4" and "ipv6" in log messages to "IPv4" and "IPv6".
It's already initialized to a non-success value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.