Skip to content

Conversation

rhansen
Copy link
Member

@rhansen rhansen commented Jul 27, 2024

No description provided.

rhansen added 16 commits July 26, 2024 19:05
From the documentation for `vars`:

> NOTE: For use with variables in the current package for a single
> scope, the functionality provided by this pragma has been superseded
> by "our" declarations, available in Perl v5.6.0 or later, and use of
> this pragma is discouraged.
It's better to start a test HTTP server or override `@curl` from tests
in `t/*.pl`.
This makes log messages easier to understand.
This is simpler, and makes it possible to distinguish unset from set
to an empty string.
The same message is already logged in `get_ipv4`.
Why issue a warning that things have suddenly started going well?
It's bizarre.
Before, the first line of a multi-line log message was prefixed with a
space while all subsequent messages were prefixed with `|`.  Now the
first line is prefixed with `>` and all subsequent lines with a space.
This makes it easier to quickly discern message boundaries.
@rhansen rhansen force-pushed the cleanups branch 2 times, most recently from 5b3a700 to 68fa2ab Compare July 27, 2024 08:18
@rhansen rhansen changed the title Various miscellaneous cleanups and improvements Various minor cleanups and improvements Jul 27, 2024
rhansen added 26 commits July 27, 2024 04:40
It's already initialized to a non-success value.
This also makes it possible to change "ipv4" and "ipv6" in log
messages to "IPv4" and "IPv6".
It's already initialized to a non-success value.
@rhansen rhansen merged commit 228efa7 into ddclient:master Jul 27, 2024
10 checks passed
@rhansen rhansen deleted the cleanups branch July 27, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant