Fix regfishde IPv6 support, repeated infomaniak force updates, and other minor issues
#691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `$proto` interpolation wasn't quoted with `\Q` and `\E`, so metacharacters in `$proto` could break the matching. Switch from a regex to an expression to fix the equality check and improve readability.
Fixes an oversight when IPv6 support was added.
If the user enabled `quietreply`, it should not become false after the first update. Users might not notice a problem because I think ddclient re-reads the config file before every check.
`mtime` should always be updated whenever the IP address is updated, otherwise ddclient will keep force updating over and over.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #553