Gandi: Personal access token support #636
Merged
+32
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WDYT about my suggested alternatives in #602 (comment)? |
|
@rhansen Re: your alternatives Option 1 is quite similar to my approach in this PR - but I slightly prefer mine with regards to transitioning users over to the personal access tokens and eventually deprecating the old API keys. Option 2 I don't like at all - trial and error pinging a provider API is something I don't want ddclient to do. |
c1ae09a to
12e9a7c
Compare
|
Maybe @LenardHess you have an idea about this issue #808 ? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #602 and is an alternative approach to #626.